Repository navigation
Fix continued fraction precision for large integers - #1
Open
Chickerson64 wants to merge 1 commit into
Open
Chickerson64 wants to merge 1 commit into
Chickerson64 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
This change fixes the precision and overflow issue described in TheAlgorithms#15655.
The
continued_fractionimplementation previously used floating-point division, which could produce incorrect continued-fraction terms or raiseOverflowErrorfor large integers.The fix replaces floating-point division with exact integer floor division and removes the unused
floorimport.Checklist
Verification
AI assistance and scope
Codex assisted with implementation and independent code review. The change was tested locally.
This is an independent educational contribution for CS440 Lab 6. Similar fixes already have open upstream PRs.
This PR is intended exclusively for my personal fork, Chickerson64/Python, and is not being submitted to TheAlgorithms upstream.